Bluetooth: RFCOMM: Move BT_RFCOMM_BUF_SIZE to rfcomm.h #83787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth Classic
jhedberg
approved these changes
Jan 10, 2025
makeshi
approved these changes
Jan 14, 2025
MarkWangChinese
approved these changes
Jan 16, 2025
|
@lylezhu2012 this needs a rebase for some reason since it doesn't want to merge despite merge button being green :) |
The buffer `BT_RFCOMM_BUF_SIZE` is used to define the TX buffer size of TX pool. In current implementation, the TX buffer size of RFCOMM cannot be calculated due to the macro `BT_RFCOMM_BUF_SIZE` is defined in internal header file `rfcomm_internal.h`. Move the macro `BT_RFCOMM_BUF_SIZE` form internal header file `rfcomm_internal.h` to interface `rfcomm.h`. Signed-off-by: Lyle Zhu <[email protected]>
lylezhu2012
force-pushed
the
move_BT_RFCOMM_BUF_SIZE_to_rfcomm_h
branch
from
2786490 to
4922b7b
Compare
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
servertobt_rfcomm_server.acceptIn current implementation, the
acceptcannot be identified if the same oneacceptcallback is passed by the upper layer.Similar with
acceptofbt_l2cap_server.accept, add a parameterserverto thebt_rfcomm_server.acceptcallback.